Skip to content

[Network] az network manager ipam-pool static-cidr update#9002

Merged
necusjz merged 8 commits intoAzure:mainfrom
p-thompson:network_manager_static_cidr_update
Aug 25, 2025
Merged

[Network] az network manager ipam-pool static-cidr update#9002
necusjz merged 8 commits intoAzure:mainfrom
p-thompson:network_manager_static_cidr_update

Conversation

@p-thompson
Copy link
Copy Markdown
Member

@p-thompson p-thompson commented Jul 25, 2025 •
edited
Loading

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings July 25, 2025 15:06
@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Jul 25, 2025 •
edited
Loading

⚠️Azure CLI Extensions Breaking Change Test
⚠️network-manager
rule cmd_name rule_message suggest_message
⚠️ 1001 - CmdAdd network manager ipam-pool static-cidr update cmd network manager ipam-pool static-cidr update added
⚠️ 1006 - ParaAdd network manager ipam-pool update cmd network manager ipam-pool update added parameter address_prefixes
⚠️ 1006 - ParaAdd network manager ipam-pool update cmd network manager ipam-pool update added parameter if_match
⚠️ 1006 - ParaAdd network manager ipam-pool update cmd network manager ipam-pool update added parameter parent_pool_name

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Jul 25, 2025

Hi @p-thompson,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Jul 25, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 25, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 25, 2025

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@microsoft-github-policy-service microsoft-github-policy-service bot added the Auto-Assign Auto assign by bot label Jul 25, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 25, 2025

Hi @p-thompson

Release Suggestions

Module: network-manager

  • Please log updates into to src/network-manager/HISTORY.rst
  • Update VERSION to 2.1.0 in src/network-manager/setup.py

Notes

Copilot AI reviewed Jul 25, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@calvinhzy
Copy link
Copy Markdown
Member

calvinhzy commented Jul 28, 2025

Can you fix lint/style CI issues?

@necusjz
Copy link
Copy Markdown
Member

necusjz commented Aug 6, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Aug 6, 2025

Azure Pipelines successfully started running 2 pipeline(s).

p-thompson and others added 3 commits August 7, 2025 10:46
@p-thompson
Merge branch 'main' into network_manager_static_cidr_update
27419d0
@calvinhzy
Merge remote-tracking branch 'upstream/main' into network_manager_sta…
2adde95 
…tic_cidr_update

# Conflicts:
#	src/network-manager/azext_network_manager/tests/latest/recordings/test_network_manager_reachability_analysis_run.yaml
#	src/network-manager/azext_network_manager/tests/latest/recordings/test_network_manager_static_cidr_crud.yaml
@p-thompson
update test
8c7a528
@necusjz
Copy link
Copy Markdown
Member

necusjz commented Aug 11, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Aug 11, 2025

Azure Pipelines successfully started running 2 pipeline(s).

@necusjz
Copy link
Copy Markdown
Member

necusjz commented Aug 25, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Aug 25, 2025

Azure Pipelines successfully started running 2 pipeline(s).

@necusjz necusjz merged commit e515ca5 into Azure:main Aug 25, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@necusjz necusjz necusjz approved these changes

@kairu-ms kairu-ms Awaiting requested review from kairu-ms kairu-ms is a code owner

@jsntcy jsntcy Awaiting requested review from jsntcy jsntcy is a code owner

@yonzhan yonzhan Awaiting requested review from yonzhan

Assignees

@necusjz necusjz

Labels

Auto-Assign Auto assign by bot Network - Network Manager Network

Projects

None yet

Milestone

August 2025 (2025-08-05)

Development

Successfully merging this pull request may close these issues.

5 participants

@p-thompson @yonzhan @calvinhzy @necusjz